Skip to content

server/requestlog: request logging unconditionally consumes entire body #2848

New issue
New issue
Closed
#3274
Closed
server/requestlog: request logging unconditionally consumes entire body#2848
#3274
@zombiezen

Description

@zombiezen
zombiezen
opened on Aug 22, 2020

Offending lines:

go-cloud/server/requestlog/requestlog.go

Lines 84 to 88 in 012388a

if rcc.err == nil && rcc.r != nil && !w2.hijacked {
// If the handler hasn't encountered an error in the Body (like EOF),
// then consume the rest of the Body to provide an accurate rcc.n.
io.Copy(ioutil.Discard, rcc)
}

For servers that take in large requests, especially those that rely on HTTP 100 Continue to bail early, this can cause a request to be stalled for much longer than necessary to reject a request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions