Skip to content

tpm2: Fix typo in MakeCredential cmd #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

loicsikidi
Copy link
Contributor

fix #390

@loicsikidi loicsikidi requested review from alexmwu, jkl73 and a team as code owners March 19, 2025 06:51
Copy link

google-cla bot commented Mar 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: loicsikidi <loic.sikidi@gmail.com>
@loicsikidi loicsikidi force-pushed the feat/tpm2/fix-make-credential-typo branch from 55c9ba9 to 6363e30 Compare March 19, 2025 07:04
@jkl73
Copy link
Contributor

jkl73 commented Mar 19, 2025

lgtm, even though it is a breaking change, should be easy for downstream to fix, @chrisfenner wdyt?

@chrisfenner chrisfenner merged commit 11143c1 into google:main Mar 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible Typo in MakeCredential Method?
3 participants