Skip to content

add TPM2_PolicyDuplicationSelect #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024
Merged

add TPM2_PolicyDuplicationSelect #365

merged 3 commits into from
Aug 12, 2024

Conversation

salrashid123
Copy link
Contributor

Adds TPM2_PolicyDuplicationSelect as described in

pg 247 23.15 TPM2_PolicyDuplicationSelect

Specifically, this allows for direct control where the duplication can occur

the test cases included here are basic. i can add an end-to-end gist where a key with this policy is created and imported on a second TPM (todo is the -ve test where its on a 3rd unauthorized TPM )

@chrisfenner

Signed-off-by: sal rashid <salrashid123@gmail.com>
@salrashid123 salrashid123 requested review from alexmwu, jkl73 and a team as code owners August 5, 2024 13:50
Signed-off-by: sal rashid <salrashid123@gmail.com>
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the poor response SLO, still have a concern about the design of the test.

Signed-off-by: sal rashid <salrashid123@gmail.com>
@salrashid123
Copy link
Contributor Author

@chrisfenner thanks; can someone trigger the tests? (they do pass but it seems there was a timeout/resource issue with the test vm provisioning)

@chrisfenner
Copy link
Member

Yeah I re-triggered them a while ago... maybe they need to be re-rerun. I'll override this check if it's failing and preventing checkin today.

@chrisfenner
Copy link
Member

cirrus CI is having a bad day, will force merge this

@chrisfenner chrisfenner merged commit 1642fe0 into google:main Aug 12, 2024
1 of 4 checks passed
@salrashid123 salrashid123 deleted the add_PolicyDuplicationSelect branch August 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants