Replay google/master work since the start of tpmdirect #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For windows, each function is available on different OS versions. To avoid panic, Check if are available before calling the function.
brandonweeks
approved these changes
Jun 12, 2023
alexmwu
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks 4 of the 5 commits that
masterhad since the start oftpmdirectatopmain(which has just been created based ontpmdirect).Big picture: we will release this* as "major prerelease"
0.9.0of go-tpm, to share the new tpmdirect API with external users.*minor change,
Startup_will be renamed toStartup, a change that has to be coordinated with go-tpm-tools migrating to use the legacy API via its new path16613e2 is not included because we had already updated to an even more recent version of
golang.org/x/sys(0.5.0)This PR also includes a minor lint-fixing commit based on issues identified by checks on this PR.
This mainly replays some work that happened in tpm2/credactivation into legacy/tpm2/credactivation.
The only interesting conflicts occurred in e782111. I've undone changes to credactivation 0b55c34 in favor of taking the code exactly as-is after @brandonweeks changes. I don't recall why I touched this file as part of introducing tpmdirect; I suspect it was to make a build or linter happy.