Skip to content

Check if are available before calling the function #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jclab-joseph
Copy link
Contributor

For windows, each function is available on different OS versions.
To avoid panic, Check if are available before calling the function.

@jclab-joseph jclab-joseph requested a review from a team as a code owner April 4, 2023 02:13
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this change!

@chrisfenner chrisfenner merged commit 3270509 into google:master Apr 4, 2023
chrisfenner added a commit that referenced this pull request Jun 13, 2023
* Bump golangci-lint to 1.52.2 (#320)

* Suport ECC EKs for credential activation (#318)

* Accept *ecdsa.PublicKey and transmute to *ecdh.PublicKey (#323)

* Check if are available before calling the function (#324)

For windows, each function is available on different OS versions.
To avoid panic, Check if are available before calling the function.

* Fix some issues identified by golangci linter

---------

Co-authored-by: Brandon Weeks <bweeks@google.com>
Co-authored-by: Joseph Lee <joseph@jc-lab.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants