TPM2: Add String function for tpm2.Algorithm #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twitchy-jsonp
suggested changes
Jan 19, 2021
There was a problem hiding this comment.
Can you make the implementation implement Stringer? https://golang.org/pkg/fmt/#Stringer
For the case where the alg is not recognized, can you return something like fmt.Sprintf("Alg?<%d>", int(a)) ?
Not ideal, but better than the empty string imo.
…experience Signed-off-by: Christopher Meis <christopher.meis@9elements.com>
e457e5e to
3b2ee69
Compare
twitchy-jsonp
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add String function for tpm2.Algorithm to brighten everyones parsing experience
Signed-off-by: Christopher Meis christopher.meis@9elements.com