Make pcapgo EthernetHandle use runtime poller #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, the EthernetHandle fd is kept in the blocking mode. Which means when capturing traffic, entire OS thread is blocked in recvmsg syscall most of the time. It's possible to use custom fds (i.e. not created by net package) with the runtime poller, so using them will be as efficient as it is with e.g. TCP sockets. This commit does exactly that.
9fb6d85 to
03f63b0
Compare
|
hey mate. I'm happy to merge this into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the
EthernetHandlefd is kept in the blocking mode. Which means when capturing traffic, entire OS thread is blocked inrecvmsgsyscall most of the time.It's possible to use custom fds (i.e. not created by
netpackage) with the runtime poller, so using them will be as efficient as it is with e.g. TCP sockets.This PR does exactly that.