dart: use enhanced enums #8313
Merged
dart: use enhanced enums #8313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6544e6 to
714941e
Compare
714941e to
e68854e
Compare
|
Hello, is there any new information about this pr? |
|
@aardappel Sorry to tag you out of the blue. Can you promote the merger of PR? |
|
This seems a nice improvement :) |
aardappel
approved these changes
Nov 18, 2024
Closed
razvanalex
pushed a commit
to razvanalex/flatbuffers
that referenced
this pull request
Dec 3, 2024
* dart: rename enums.fbs * feat: use dart enhanced enums * generate code --------- Co-authored-by: Wouter van Oortmerssen <aardappel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart has had enhanced enums for a few years so we can now use it instead of our hacky class with static fields.
User code should be mostly unaffected, other than using the defaullt toString() now (closes #8260) and the change in
.valuestype. Both now default to standard dart enum behavior.