[Swift] Adds swift 6 to the build matrix & bumps swift to 5.9 #8414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e34e70 to
d90e7be
Compare
d90e7be to
1532933
Compare
Bump min version of swift to be 5.9
1532933 to
683de5d
Compare
dbaileychess
approved these changes
Feb 4, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Apr 9, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `FlatBuffers` to `v25.2.10` from `v24.3.7`. ### Why are the changes needed? `FlatBuffers` `v24.3.7` was released over one year ago (on Mar 8, 2024), we had better use the latest version in order to support `Swift 6` officially. - https://github.com/google/flatbuffers/releases/tag/v25.2.10 (2025-02-11) - google/flatbuffers#8414 - https://github.com/google/flatbuffers/releases/tag/v25.1.24 (2025-01-25) - https://github.com/google/flatbuffers/releases/tag/v25.1.21 (2025-01-22) - https://github.com/google/flatbuffers/releases/tag/v24.12.23 (2024-12-24) - google/flatbuffers#8330 - https://github.com/google/flatbuffers/releases/tag/v24.3.25 (2024-03-26) ### Does this PR introduce _any_ user-facing change? No. There is no behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48 from dongjoon-hyun/SPARK-51750. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This was referenced Apr 28, 2025
kou
pushed a commit
to apache/arrow
that referenced
this pull request
May 1, 2025
### Rationale for this change `FlatBuffers` `v24.3.7` was released over one year ago (on Mar 8, 2024), we had better use the latest version in order to support `Swift 6+` officially. - https://github.com/google/flatbuffers/releases/tag/v25.2.10 (2025-02-11) - google/flatbuffers#8414 - https://github.com/google/flatbuffers/releases/tag/v25.1.24 (2025-01-25) - https://github.com/google/flatbuffers/releases/tag/v25.1.21 (2025-01-22) - https://github.com/google/flatbuffers/releases/tag/v24.12.23 (2024-12-24) - google/flatbuffers#8330 - https://github.com/google/flatbuffers/releases/tag/v24.3.25 (2024-03-26) ### What changes are included in this PR? Use the latest `v25.2.10` instead of `v24.3.7`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46245 Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
raulcd
pushed a commit
to apache/arrow-swift
that referenced
this pull request
May 29, 2025
### Rationale for this change `FlatBuffers` `v24.3.7` was released over one year ago (on Mar 8, 2024), we had better use the latest version in order to support `Swift 6+` officially. - https://github.com/google/flatbuffers/releases/tag/v25.2.10 (2025-02-11) - google/flatbuffers#8414 - https://github.com/google/flatbuffers/releases/tag/v25.1.24 (2025-01-25) - https://github.com/google/flatbuffers/releases/tag/v25.1.21 (2025-01-22) - https://github.com/google/flatbuffers/releases/tag/v24.12.23 (2024-12-24) - google/flatbuffers#8330 - https://github.com/google/flatbuffers/releases/tag/v24.3.25 (2024-03-26) ### What changes are included in this PR? Use the latest `v25.2.10` instead of `v24.3.7`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46245 Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds swift 6 to the matrix to insure that all the new features and current implementations are compatible with safe concurrency and the new swift features, and dropping support for 5.8 on the CI.