Skip to content

Conversation

mustiikhalil
Copy link
Collaborator

The following PR fixes a bug where we skip capacity verification on the IDs and that leads to an assertion or a crash depending on the environment using the lib.

Closes: #8408

@github-actions github-actions bot added the swift label Oct 1, 2024
@mustiikhalil mustiikhalil self-assigned this Oct 1, 2024
@mustiikhalil mustiikhalil force-pushed the mmk/fix-throwing-id-check branch from 73b46ed to 802bd39 Compare October 1, 2024 21:31
@mustiikhalil mustiikhalil merged commit d7a70db into google:master Oct 4, 2024
48 checks passed
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
@mustiikhalil mustiikhalil deleted the mmk/fix-throwing-id-check branch November 18, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swift getCheckedRoot(fileId: ) will assert on buffer < (8?) bytes rather than throw. [swift, swiftc 6.0, OSX, 24.3.25]
2 participants