Fix python tests #7960
Fix python tests #7960
Conversation
Regressed from #7529
GitHub Actions runs `bash PythonTest.sh`, and thus failures were not visible.
|
Could you also update the CI builds? |
|
I have not reviewed the contents of this PR or checked whether it fully solves the referenced bugs. I have verified that, after rebasing this PR to the 23.5.9 release and applying it as a patch to the Fedora Linux Still, I’m holding off on updating the package in Fedora Rawhide from 23.3.3 until things settle out a bit—probably waiting for the next release. (Since |
|
@maxburke Can you comment, as you introduce these changes. |
I remember that we used dot-prefixed imports to sort out some issues where Python couldn't resolve some paths. I can't remember the exact reason why. If there are tests that pass when this is merged that don't otherwise then let's merge this change and I can sort out any of the failures I'm encountering at a later date. |
|
Thanks, I pushed another commit to fix CI. This should be ready for reviews now. |
|
The test failure seems unrelated: (https://buildkite.com/bazel/flatbuffers/builds/8508#018826d1-4342-4d50-a470-4095f006948c) |
|
Thanks! |
* Don't generate types unless --python-typing specified Fixes google#7944 * Fix incorrect import statements Fixes google#7951 * Fix $PYTHONPATH in PythonTest.sh Regressed from google#7529 * PythonTest: fail if something goes wrong GitHub Actions runs `bash PythonTest.sh`, and thus failures were not visible. * Build flatc for Python tests * Regenerate codes --------- Co-authored-by: Derek Bailey <derekbailey@google.com>
* Don't generate types unless --python-typing specified Fixes google#7944 * Fix incorrect import statements Fixes google#7951 * Fix $PYTHONPATH in PythonTest.sh Regressed from google#7529 * PythonTest: fail if something goes wrong GitHub Actions runs `bash PythonTest.sh`, and thus failures were not visible. * Build flatc for Python tests * Regenerate codes --------- Co-authored-by: Derek Bailey <derekbailey@google.com>
WIP - create a PR to see if tests are correctly run
Thank you for submitting a PR!
Please delete this standard text once you've created your own description.
If you make changes to any of the code generators (
src/idl_gen*) be sure tobuild your project, as it will generate code based on the changes. If necessary
the code generation script can be directly run (
scripts/generate_code.py),requires Python3. This allows us to better see the effect of the PR.
If your PR includes C++ code, please adhere to the
Google C++ Style Guide,
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
so only some C++11 support is available.
For any C++ changes, please make sure to run
sh scripts/clang-format-git.shInclude other details as appropriate.
Thanks!