Skip to content

Conversation

faucct
Copy link
Contributor

@faucct faucct commented Apr 12, 2023

#7696
The binary size grows from 5.8MB to 7.2MB, but this way it works on Ubuntu 18.04 and amazonlinux.

@google-cla
Copy link

google-cla bot commented Apr 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the CI Continuous Integration label Apr 12, 2023
dbaileychess
dbaileychess previously approved these changes Apr 26, 2023
@dbaileychess dbaileychess enabled auto-merge (squash) April 26, 2023 05:14
@faucct
Copy link
Contributor Author

faucct commented Apr 26, 2023

@dbaileychess , once again, please.

auto-merge was automatically disabled April 26, 2023 05:34

Head branch was pushed to by a user without write access

@dbaileychess dbaileychess enabled auto-merge (squash) April 26, 2023 05:34
@faucct
Copy link
Contributor Author

faucct commented Apr 26, 2023

I have pushed the merge commit again, though I don't see it in the feed. Once again, I guess?

google#7696
The binary size grows from 5.8MB to 7.2MB, but this way it works on Ubuntu 18.04 and amazonlinux.
@dbaileychess dbaileychess disabled auto-merge April 26, 2023 05:39
@dbaileychess dbaileychess merged commit f6af208 into google:master Apr 26, 2023
@dbaileychess
Copy link
Collaborator

Done

@faucct
Copy link
Contributor Author

faucct commented Apr 26, 2023

Thanks! Can this get a version, please?

jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
google#7696
The binary size grows from 5.8MB to 7.2MB, but this way it works on Ubuntu 18.04 and amazonlinux.
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
google#7696
The binary size grows from 5.8MB to 7.2MB, but this way it works on Ubuntu 18.04 and amazonlinux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants