Skip to content

Shortcode 'card': trimming of whitespace #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

Shortcode 'card': trimming of whitespace #2278

merged 1 commit into from
Jun 5, 2025

Conversation

deining
Copy link
Contributor

@deining deining commented Jun 5, 2025 •
edited by chalin
Loading

This code

{{< card code=true header="My Header" lang="go-html-template" highlight="linenos=inline,lineNoStart=1" >}}
First line
{{< /card >}}

is currently rendered to:

My Header
1 
2 First line

This PR fixes that issue.

Preview: https://deploy-preview-2278--docsydocs.netlify.app/docs/adding-content/shortcodes/#shortcode-card-programming-code

@deining deining requested a review from chalin June 5, 2025 14:28
@deining deining force-pushed the fix-card-shortcode branch from 087fccd to f901bb8 Compare June 5, 2025 17:55
chalin
chalin reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, once checks pass.

@deining deining force-pushed the fix-card-shortcode branch from f901bb8 to ccda856 Compare June 5, 2025 18:36
@deining deining requested a review from chalin June 5, 2025 18:38
@chalin chalin merged commit a824b2a into google:main Jun 5, 2025
11 checks passed
@deining deining deleted the fix-card-shortcode branch June 5, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chalin chalin chalin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @chalin