Skip to content

Conversation

Gr3q
Copy link
Contributor

@Gr3q Gr3q commented May 18, 2025

I've found that the examples don't work with the current version included in some cases, see opensubsonic/open-subsonic-api#137. In that case updating to the latest swagger version seems to solve the problem.

Copy link

google-cla bot commented May 18, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

I've found that the examples don't work with the current version included.
@chalin
Copy link
Contributor

chalin commented May 27, 2025

@theletterf - WDYT?

@theletterf
Copy link
Contributor

@Gr3q Thanks! An update was due anyway, though I'd like to see what OAS snippet wasn't rendering properly. Could you share the OAS and show a screenshot of the issue?

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gr3q - thanks for the PR. Please provide the screenshot @theletterf requested as soon as you can. I'll go ahead and merge now.

@chalin chalin merged commit f15d519 into google:main May 27, 2025
11 checks passed
@Gr3q
Copy link
Contributor Author

Gr3q commented May 27, 2025

I checked again, we were using docsy 0.5.1, changing to unpkg in 0.7.2 fixed this issue already. This is how the examples looked before. This is the OAS file: https://opensubsonic.netlify.app/docs/openapi/openapi.json

Screenshot_2025-05-27_22-25-29
Screenshot_2025-05-27_22-25-16

@Gr3q Gr3q deleted the patch-1 branch May 27, 2025 21:28
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants