Use font-weight-bold variable #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
chalin
reviewed
May 14, 2025
There was a problem hiding this comment.
Thanks. Instead use $font-weight-bold (as defined in https://getbootstrap.com/docs/5.3/utilities/text/#sass-variables).
chalin
reviewed
May 27, 2025
chalin
approved these changes
May 27, 2025
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
May 30, 2025
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the css variable
font-weight-boldinstead of hardcoding the font weight to 700. Two files still used the hard coded font weight. Sincefont-weight-bolddefaults to 700, the default styling is not impacted.