Rename Docsy's render-heading hook and helper partial #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the Docsy render-heading hook and associated heading self-link helper to enable a cleaner refactoring and update the relevant documentation.
- Renames the partial from the old template naming to a new partial-based naming scheme.
- Updates documentation and CHANGELOG to reflect these renames.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| userguide/layouts/_default/_markup/render-heading.html | Updated to call the new partial "td/render-heading.html". |
| userguide/content/en/docs/adding-content/navigation.md | Documentation changes to reflect the new partial names. |
| layouts/partials/td/render-heading.html | Renamed partial invocation & definition for heading self-link. |
| CHANGELOG.md | Updates reflecting the breaking changes in naming. |
Files not reviewed (1)
- userguide/static/refcache.json: Language not supported
2 tasks
4f84770 to
05e8446
Compare
05e8446 to
66e8a56
Compare
|
Merging. Feedback is still welcome. |
|
Successfully tested via OTel website: |
|
Looks much clearer, thanks! |
fekete-robert
pushed a commit
to fekete-robert/docsy
that referenced
this pull request
May 30, 2025
Yuan325
added a commit
to googleapis/genai-toolbox
that referenced
this pull request
Jun 4, 2025
There's a `no such template "_default/_markup/td-render-heading.html"` error when running `hugo server` locally. This is due to a breaking change in [Hugo v0.146.0](https://github.com/gohugoio/hugo/releases/tag/v0.146.0). This PR updates the render-heading file according to google/docsy#2223.
github-actions bot
pushed a commit
to googleapis/genai-toolbox
that referenced
this pull request
Jun 4, 2025
There's a `no such template "_default/_markup/td-render-heading.html"` error when running `hugo server` locally. This is due to a breaking change in [Hugo v0.146.0](https://github.com/gohugoio/hugo/releases/tag/v0.146.0). This PR updates the render-heading file according to google/docsy#2223. 9ecf175
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Jun 4, 2025
There's a `no such template "_default/_markup/td-render-heading.html"` error when running `hugo server` locally. This is due to a breaking change in [Hugo v0.146.0](https://github.com/gohugoio/hugo/releases/tag/v0.146.0). This PR updates the render-heading file according to google/docsy#2223. 9ecf175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.