Skip to content

Conversation

deining
Copy link
Contributor

@deining deining commented Feb 14, 2025

This PR closes #2189. All issues mentioned in this ticket are resolved now.

@deining deining requested a review from chalin February 14, 2025 21:22
@deining deining changed the title Ug math hugo v0.122 User guide, LaTeX: typesetting of formulae using standard syntax (II) Feb 14, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and resolve conflicts.

@deining deining force-pushed the ug-math-hugo-v0.122 branch from 570db2b to 2360240 Compare May 27, 2025 12:34
@deining deining force-pushed the ug-math-hugo-v0.122 branch 2 times, most recently from c5ae860 to 96f1925 Compare May 27, 2025 12:54
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refcache needs updating and the following link (hash) is invalid:

docs/adding-content/diagrams-and-formulae/index.html
  hash does not exist --- docs/adding-content/diagrams-and-formulae/index.html --> /docs/adding-content/diagrams-and-formulae/#activating-rendering-support-for-chemical-formulae

@deining deining force-pushed the ug-math-hugo-v0.122 branch from 96f1925 to 26f4ed4 Compare May 27, 2025 12:58
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More copyedits, see inline comments.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM once the typos and copyedits are addressed and all checks pass. Thanks.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM for the code changes. Doc changes seem fine.

@chalin chalin merged commit dbfb6c4 into google:main May 27, 2025
11 checks passed
@deining deining deleted the ug-math-hugo-v0.122 branch May 27, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest LaTeX PR causes square brackets to be escaped, breaks ToC rendering, and more
3 participants