-
Notifications
You must be signed in to change notification settings - Fork 945
User guide, LaTeX: typesetting of formulae using standard syntax (II) #2195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and resolve conflicts.
570db2b
to
2360240
Compare
userguide/content/en/docs/adding-content/diagrams-and-formulae/index.md
Outdated
Show resolved
Hide resolved
userguide/content/en/docs/adding-content/diagrams-and-formulae/index.md
Outdated
Show resolved
Hide resolved
c5ae860
to
96f1925
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refcache needs updating and the following link (hash) is invalid:
docs/adding-content/diagrams-and-formulae/index.html
hash does not exist --- docs/adding-content/diagrams-and-formulae/index.html --> /docs/adding-content/diagrams-and-formulae/#activating-rendering-support-for-chemical-formulae
96f1925
to
26f4ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More copyedits, see inline comments.
userguide/content/en/docs/adding-content/diagrams-and-formulae/index.md
Outdated
Show resolved
Hide resolved
userguide/content/en/docs/adding-content/diagrams-and-formulae/index.md
Outdated
Show resolved
Hide resolved
userguide/content/en/docs/adding-content/diagrams-and-formulae/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM once the typos and copyedits are addressed and all checks pass. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM for the code changes. Doc changes seem fine.
This PR closes #2189. All issues mentioned in this ticket are resolved now.