Skip to content

[feat] Add base support of td-content-after-header hook #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 10, 2025
Merged

[feat] Add base support of td-content-after-header hook #2192

merged 2 commits into from
Feb 10, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 10, 2025 •
edited
Loading

Important

This preliminary core feature implementation is experimental.

  • Adds a "render hook" for page content right after the td-content <header>, and so just before the page .Content.
  • Adds nothing more so that projects can experiment with use of site/page params etc. Docsy isn't ready yet to commit to richer solutions for Add a feature to warn readers that a blog post may be outdated. #1773 and the like.
  • The base hook template is empty.
  • Processes the template using .Render, which means that template lookup is based on content type.

@chalin chalin added the enhancement New feature or request label Feb 10, 2025
@chalin chalin force-pushed the chalin-im-td-content-after-header-hook-2025-02-10 branch from 9e56023 to 343439a Compare February 10, 2025 16:25
@chalin chalin merged commit 2239156 into google:main Feb 10, 2025
11 checks passed
@chalin chalin deleted the chalin-im-td-content-after-header-hook-2025-02-10 branch February 10, 2025 20:30
This was referenced Feb 10, 2025
Merged
Open
@chalin chalin added this to the 25Q1 milestone Feb 10, 2025
@chalin chalin mentioned this pull request Feb 10, 2025
Open
@chalin
Copy link
Contributor Author

chalin commented May 22, 2025

@LisaFC - I've added some minimal entry to the UG for this feature:

@chalin chalin mentioned this pull request May 27, 2025
Closed
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
@chalin @fekete-robert
[feat] Add base support of td-content-after-header hook (google#2192)
9ab72aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
25Q1
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @LisaFC