Skip to content

[UG] Give guidance on what to do on "failed to load modules" error #2117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

[UG] Give guidance on what to do on "failed to load modules" error #2117

merged 2 commits into from
Nov 6, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 6, 2024 •
edited
Loading

@chalin chalin requested a review from LisaFC November 6, 2024 15:06
@chalin
Copy link
Contributor Author

chalin commented Nov 6, 2024

/cc @sftim

@chalin chalin force-pushed the chalin-im-080-build-note-2024-11-06 branch from 5d43f80 to bfdf486 Compare November 6, 2024 15:17
@chalin chalin merged commit 55e0ce2 into google:main Nov 6, 2024
11 checks passed
@chalin chalin deleted the chalin-im-080-build-note-2024-11-06 branch November 6, 2024 15:40
@chalin chalin added this to the 24Q4 milestone Nov 6, 2024
@sftim
Copy link

sftim commented Nov 6, 2024

A related concern; the postinstall I think runs cp -R node_modules/bootstrap/scss/vendor/* assets/_vendor/bootstrap/scss/ and this is making assumptions about both the current working directory and the name of the install target.

Seems like NPM might not guarantee those are always the right values to make that command work.

@chalin
Copy link
Contributor Author

chalin commented Nov 6, 2024

For the cp command, we've switched to use of the NPM cpy-cli command. As for the working directory, I'll leave that as is for now. We can address any specific issues if/when they arise.

@chalin
Copy link
Contributor Author

chalin commented Nov 6, 2024 •
edited
Loading

@sftim - btw, unless you run ci:prepare, you won't hit the copy commands. The ci:prepare script is only for those maintaining and releasing Docsy.

fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
@chalin @fekete-robert
[UG] Give guidance on what to do on "failed to load modules" error (g…
35622fd 
…oogle#2117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q4
Development

Successfully merging this pull request may close these issues.

[CI] Docsy 0.8.0 NPM-package postinstall may fail to run
3 participants
@chalin @sftim @LisaFC