Skip to content

Adds a warning when truncating sidebar section entries #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2024
Merged

Adds a warning when truncating sidebar section entries #2069

merged 4 commits into from
Aug 8, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 7, 2024 •
edited
Loading

@chalin
Copy link
Contributor Author

chalin commented Aug 7, 2024

@fekete-robert et al. PTAL

@chalin chalin mentioned this pull request Aug 7, 2024
Closed
@chalin chalin added this to the 24Q3 milestone Aug 7, 2024
@chalin chalin changed the title Adds a warning when truncating menu list in sidebar-tree.html Adds a warning when truncating sidebar section entries Aug 7, 2024
@chalin chalin mentioned this pull request Aug 7, 2024
Closed
2 tasks
fekete-robert
fekete-robert approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@fekete-robert fekete-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin chalin merged commit 7951194 into main Aug 8, 2024
13 checks passed
@chalin chalin deleted the patch-1 branch August 8, 2024 13:23
@chalin
Copy link
Contributor Author

chalin commented Aug 8, 2024 •
edited
Loading

Thanks!

Thank you @fekete-robert! 🙏

fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
@chalin @fekete-robert
Adds a warning when truncating sidebar section entries (google#2069)
a9e1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC LisaFC approved these changes

@emckean emckean Awaiting requested review from emckean

@deining deining Awaiting requested review from deining

@geriom geriom Awaiting requested review from geriom

+1 more reviewer

@fekete-robert fekete-robert fekete-robert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q3
Development

Successfully merging this pull request may close these issues.
3 participants
@chalin @fekete-robert @LisaFC