Skip to content

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 25, 2023

Currently, we cannot run docsy as module with HEAD of repo. This PR fixes that by bumping _rfs.scss used by docsy dependencies to the latest bootstrap version 5.2.3.
This also affects #1217, I will update that PR accordingly. Were great if #1217 could be reviewed soon.

@deining deining requested a review from chalin January 25, 2023 09:39
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin
Copy link
Contributor

chalin commented Jan 25, 2023

Were great if #1217 could be reviewed soon.

I agree, it's been toward the top of my list, but the second half of 2022 was very busy for me. Atm, all of my focus is on the BS5 upgrade. I'll get to it as soon as I can after that. Thanks for your patience!

@chalin chalin merged commit 798c250 into google:main Jan 25, 2023
@deining deining mentioned this pull request Jan 25, 2023
50 tasks
@deining deining deleted the bs5-module branch January 29, 2023 11:29
dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants