Skip to content

CHANGELOG: add breaking change (tabbed panes, text display) #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2022
Merged

CHANGELOG: add breaking change (tabbed panes, text display) #1298

merged 1 commit into from
Oct 29, 2022

Conversation

deining
Copy link
Contributor

@deining deining commented Oct 28, 2022

Docsy version v0.5.0: for tabbed panes, the name of the parameter for textual display changed from code=false to text=true. This PR documents this breaking change in CHANGELOG.md (see#1295).

@deining deining requested a review from chalin October 28, 2022 15:29
chalin
chalin approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deining deining merged commit d9bf98b into google:main Oct 29, 2022
@deining deining mentioned this pull request Oct 29, 2022
Closed
@deining deining deleted the changelog branch October 29, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chalin chalin chalin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @chalin