Skip to content

section-index.html code cleanup #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2024
Merged

section-index.html code cleanup #1947

merged 1 commit into from
Apr 26, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Apr 25, 2024 •
edited
Loading

@chalin chalin requested review from fekete-robert and deining April 25, 2024 17:05
@chalin chalin added this to the 24Q2 milestone Apr 25, 2024
This was referenced Apr 25, 2024
Closed
Closed
deining
deining approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked this simplification on an existing site that caused problems in the past and it worked well, so LGTM.

tobiaskohlbau
tobiaskohlbau approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tobiaskohlbau tobiaskohlbau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response in my PR was quite busy the last couple of days. Checked out this PR and tested it. Works like expected for the site having issuers earlier.

fekete-robert
fekete-robert approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@fekete-robert fekete-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin force-pushed the chalin-im-section-index-2024-04-25 branch from 7ad3577 to 2348b53 Compare April 26, 2024 15:03
@chalin
Copy link
Contributor Author

chalin commented Apr 26, 2024 •
edited
Loading

Thanks all for your reviews and feedback.

Btw, I don't like having two variables that differ only in one character, such as $page and $pages, but this'll do for now.

@chalin chalin merged commit bedcb9c into google:main Apr 26, 2024
@chalin chalin deleted the chalin-im-section-index-2024-04-25 branch April 26, 2024 15:06
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
@chalin @fekete-robert
section-index.html code cleanup (google#1947)
b0fd7be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@tobiaskohlbau tobiaskohlbau tobiaskohlbau approved these changes

@fekete-robert fekete-robert fekete-robert approved these changes

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q2
Development

Successfully merging this pull request may close these issues.

section-index.html: code cleanup
4 participants
@chalin @tobiaskohlbau @fekete-robert @deining