Skip to content

[Dark-mode] Tweak of param, file and resource names #1913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2024
Merged

[Dark-mode] Tweak of param, file and resource names #1913

merged 2 commits into from
Apr 5, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Apr 5, 2024 •
edited
Loading

  • Contributes to Support dark mode #331
  • Followup to Color-mode / dark-mode support #1909
  • Renames BS color-modes.js to dark-mode.js
  • Renames local-storage key so that it's Docsy specific
  • Relocates the light/dark-mode drop-down menu styles into the SCSS assets folder
  • Renames the config param to showLightDarkModeMenu

/cc @geriom

@chalin chalin mentioned this pull request Apr 5, 2024
Closed
26 tasks
@chalin chalin added the enhancement New feature or request label Apr 5, 2024
@chalin
Copy link
Contributor Author

chalin commented Apr 5, 2024

Going to merge now; more changes will follow.
@geriom, et al.: feedback is still welcome.

@chalin chalin merged commit 4e56448 into google:main Apr 5, 2024
@chalin chalin deleted the chalin-im-dark-mode-contd-2024-03-30 branch April 5, 2024 19:43
@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
24Q2
Development

Successfully merging this pull request may close these issues.
1 participant
@chalin