Skip to content

Color-mode / dark-mode support #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2024
Merged

Color-mode / dark-mode support #1909

merged 1 commit into from
Mar 30, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Mar 28, 2024 •
edited
Loading

  • Contributes to Support dark mode #331
  • The Bootstrap docs invite us to copy their color-theme picker code. Well, I did just that :)
  • Adds a color theme picker partial
  • Illustrates the use of `` in the UG, which causes the color-theme picker to be added to the end of the navbar, just before the search box
  • I'll create a changelog entry in a separate PR. My intent is to make clear that this early support is experimental in alpha, and still subject to change.

Preview: https://deploy-preview-1909--docsydocs.netlify.app/docs/

Screenshots

image

image

@chalin chalin added enhancement New feature or request UX design/style Front-end site design / styling labels Mar 28, 2024
@chalin chalin marked this pull request as draft March 28, 2024 10:33
@chalin
Copy link
Contributor Author

chalin commented Mar 28, 2024

I just noticed a few cases I missed -- for a growing list of elements to fix (usually by adjusting the background color), see the opening comment of #331. Marking this as draft in the meantime.

@chalin chalin changed the title Color-mode / dark-mode support - EXPERIMENTAL Color-mode / dark-mode support Mar 28, 2024
@chalin chalin marked this pull request as ready for review March 28, 2024 17:27
@chalin
Copy link
Contributor Author

chalin commented Mar 28, 2024

Changed my mind: let's get this in and I'll submit separate followup PRs.

@chalin chalin merged commit 003b0e6 into google:main Mar 30, 2024
@chalin chalin deleted the chalin-im-dark-mode-dev-2024-03-28 branch March 30, 2024 20:12
This was referenced Mar 30, 2024
Closed
Merged
@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@milinddethe15 milinddethe15 mentioned this pull request Jan 16, 2025
Closed
@Oxymoron290 Oxymoron290 mentioned this pull request May 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriom geriom geriom approved these changes

@emckean emckean Awaiting requested review from emckean

@fekete-robert fekete-robert Awaiting requested review from fekete-robert

@LisaFC LisaFC Awaiting requested review from LisaFC

@deining deining Awaiting requested review from deining

Assignees
No one assigned
Labels
design/style Front-end site design / styling enhancement New feature or request UX
Projects
None yet
Milestone
24Q2
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @geriom