Skip to content

Section-index: ensure .Parent isn't nil #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

Section-index: ensure .Parent isn't nil #1866

merged 1 commit into from
Feb 16, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 15, 2024 •
edited
Loading

To test, I ran the following from a local docsy repo:

$ mkdir tmp
$ cd tmp
$ ../tools/make-site.sh -s HUGO_MODULE
$ cd test-site
$ echo "---\ntitle: Hello\ntype: docs\n---\nPlaceholder" > content/_index.md
$ hugo # building or serving seems fine now

Without the fix in this PR, the commands above yield the error reported in #1863.

@chalin chalin requested a review from deining February 15, 2024 23:46
@chalin chalin mentioned this pull request Feb 15, 2024
Closed
12 tasks
@chalin
Copy link
Contributor Author

chalin commented Feb 15, 2024

/cc @marshalc @chulcher

@chulcher
Copy link

The change to 'if and .Parent .Parent.File' is working for my setup.

deining
deining approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry for introducing a regression here.

@chalin chalin merged commit 3692cb8 into google:main Feb 16, 2024
@chalin chalin deleted the chalin-parent-nil-fix-2024-02-15 branch February 16, 2024 22:28
@chalin chalin mentioned this pull request Mar 4, 2024
Closed
2 tasks
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.

0.9.0: execute of template failed at <.Parent.File>: nil pointer evaluating page.Page.File -- error when using page type docs
3 participants
@chalin @chulcher @deining