Skip to content

Conversation

deining
Copy link
Contributor

@deining deining commented Feb 9, 2024

This PR closes #1837 by addressing all four tasks listed in this issue.

The first commit alters the way the scripts are retrieved (now: at build time) and allows for custom KaTeX versions while bringing in the latest version by default.
The second commit updates and extends the section LaTe​X support with KaTe​X of user guide. This chapter now describes how one can do LaTeX or TeX typsetting directly from Markdown using standard syntax (needs hugo v0.122 or above).
There are no breaking changes introduced with this PR.

You may have a look at the preview on Netlify.

@deining deining added the user guide Improvements to user guide label Feb 9, 2024
@deining deining requested a review from chalin February 9, 2024 20:49
@deining deining force-pushed the ug-math-hugo-v0.122 branch from 17d2069 to 325cc87 Compare February 11, 2024 10:55
@chalin chalin force-pushed the ug-math-hugo-v0.122 branch from 325cc87 to 2de558f Compare March 26, 2024 22:31
@deining deining force-pushed the ug-math-hugo-v0.122 branch 2 times, most recently from 1f5c334 to b255357 Compare October 31, 2024 16:16
@deining deining force-pushed the ug-math-hugo-v0.122 branch from b255357 to 15f43bf Compare January 21, 2025 21:58
@deining
Copy link
Contributor Author

deining commented Jan 21, 2025

I just realized that my PR didn't work with hugo version 0.141.0 any more. I therefore rebased my PR and added a commit so that no error is thrown any more.
@chalin: Any chance to get that into the next release? I really would like to see this PR merged soon.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Quick initial feedback, see inline.

@LisaFC - might you be available to do a full review of the UG changes?

@chalin
Copy link
Contributor

chalin commented Jan 24, 2025

@geriom @fekete-robert - could either of your review the code?

@deining deining force-pushed the ug-math-hugo-v0.122 branch from 70308f1 to b316015 Compare January 25, 2025 08:31
@deining deining requested a review from chalin January 25, 2025 08:33
@chalin chalin force-pushed the ug-math-hugo-v0.122 branch from 1b2a9d7 to de85321 Compare February 4, 2025 17:40
@chalin
Copy link
Contributor

chalin commented Feb 4, 2025

@LisaFC et all: any feedback?

Copy link
Collaborator

@LisaFC LisaFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few little nits in the UG content

@chalin chalin force-pushed the ug-math-hugo-v0.122 branch from de85321 to 2bccb66 Compare February 4, 2025 19:51
@deining
Copy link
Contributor Author

deining commented Feb 4, 2025

@LisaFC: thanks for your feedback, all your comments/changes are added as requested.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all! RSLGTM for the layout code.

@chalin chalin merged commit 9815271 into google:main Feb 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user guide Improvements to user guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for display of mathematical formulae
3 participants