Skip to content

Smoke tests: don't cancel Windows build after an error in Linux build #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

Smoke tests: don't cancel Windows build after an error in Linux build #1857

merged 1 commit into from
Feb 13, 2024

Conversation

deining
Copy link
Contributor

@deining deining commented Feb 9, 2024

This PR follows up on #1196, issue 6 raised:

Inside the smoke tests there is a matrix defined so that tests can be reused and executed on Linux and Windows machines and for NPM and hugo module build. This seems logical, it comes with one disadvantage, though: as soon as a smoke test for Linux fails, the corresponding smoke test on Windows is cancelled.

This PR overcomes this limitation while still following the DRY principle.

@deining deining added e0-minutes Effort < 60 min CI/infra CI & infrastructure labels Feb 9, 2024
@deining deining requested a review from chalin February 9, 2024 19:28
chalin
chalin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

@chalin chalin merged commit ea7405f into google:main Feb 13, 2024
@deining deining deleted the action-matrix-no-fail-fast branch April 23, 2024 19:59
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
@renovate renovate bot mentioned this pull request Aug 10, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chalin chalin chalin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CI/infra CI & infrastructure e0-minutes Effort < 60 min
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @chalin