Smoke test: improvements #1800
Merged
Smoke test: improvements #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chalin
reviewed
Feb 1, 2024
There was a problem hiding this comment.
I appreciate the fixes, thanks.
As for the name changes, I'd prefer that you revert them, otherwise the job lists become difficult to figure out at a glance, as you can see here:
vs
Ideally, there would be a description field, but this is only a proposal at the moment, see https://github.com/orgs/community/discussions/12213.
8f0fea4 to
2d145c1
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a few improvements to the newly added smoke tests. Also see #1796 for an explanation.