-
Notifications
You must be signed in to change notification settings - Fork 944
add option to translate feedback question and options #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tobias Kohlbau <tobias@kohlbau.de>
Great! I'll send a mail to the docsy-users group to see if any other community members can add the strings to our other language bundles. |
Great idea! I've got a small question. I'm unclear where the right place is to document the option to translate the ui settings.
In addition I'm not quiet comfortable with toml. I've expierienced that I need to put the enabled in both fields as the global one get's overwritten by the language specific ones (empty key). |
For the documentation, I'd mention it in this page on feedback, under Setup: https://github.com/google/docsy/blob/master/userguide/content/en/docs/Adding%20content/feedback.md Something like "The feedback widget text itself depends on your chosen language. If your preferred language isn't supported yet, please add the text to the relevant internationalization bundle" ...and then link to the multi-language support page where it discusses the internationalization bundles: https://www.docsy.dev/docs/language/#internationalization-bundles I'll have a play around with the config for setting this up - we presumably don't want users to have to enable/disable feedback on a per-language basis. |
Haven't forgotten about this, btw, was travelling for work - will play around with the config this week. |
Hello @LisaFC, do you think we could get this merged? Would be really awesome! Thanks! |
Thanks for the reminder! I'll have a look at the files, I seem to remember they weren't quite right/ready to merge. |
I'm eager to address any open changes to align with the project. I will try to have another look from my side in the upcoming days. |
Fixes #175
Would like to gather more languages. Any chance there are people around who speak the missing languages?