Skip to content

RSS button: link to XML via RelPermalink #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2024
Merged

RSS button: link to XML via RelPermalink #1786

merged 1 commit into from
Jan 15, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jan 15, 2024 •
edited
Loading

@chalin
Copy link
Contributor Author

chalin commented Jan 15, 2024

/cc @fekete-robert

deining
deining approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit ce52bb0 into google:main Jan 15, 2024
@chalin chalin deleted the chalin-im-rss-as-path-2024-01-15 branch January 15, 2024 20:26
@chalin chalin added this to the 24Q1 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emckean emckean Awaiting requested review from emckean

@fekete-robert fekete-robert Awaiting requested review from fekete-robert

@geriom geriom Awaiting requested review from geriom

1 more reviewer

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
24Q1
Development

Successfully merging this pull request may close these issues.

RSS references should be encoded as local paths not external URLs
2 participants
@chalin @deining