Skip to content

NPM dependencies: Update font-awesome package to include new twitter logo #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2023
Merged

NPM dependencies: Update font-awesome package to include new twitter logo #1754

merged 3 commits into from
Dec 8, 2023

Conversation

venkateswarluvajrala
Copy link
Contributor

Fixes: #1753

@google-cla Google CLA
Copy link

google-cla bot commented Nov 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

deining
deining suggested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
This PR takes care of the npm dependency. We have font-awesome as module dependency too, which also needs to be updated.
@venkyvajrala: can you add this missing part to the PR as well, please?

@venkateswarluvajrala
Copy link
Contributor Author

@deining Updated module dependency for font-awesome library.

This was referenced Dec 6, 2023
Closed
Closed
deining
deining approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

chalin
chalin approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

FYI: In the past we've had patch updates to FA that affecting spacing, which is why I preferred waiting for 0.8.0 to be released first.

@chalin chalin merged commit 1092a03 into google:main Dec 8, 2023
@chalin chalin mentioned this pull request Dec 8, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@chalin chalin chalin approved these changes

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPM dependencies: Update font-awesome version which includes new Twitter logo
3 participants
@venkateswarluvajrala @chalin @deining