Skip to content

Use SCSS join() rather than prepend() #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2023
Merged

Use SCSS join() rather than prepend() #1736

merged 2 commits into from
Nov 13, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 13, 2023

@chalin chalin requested review from LisaFC and geriom November 13, 2023 12:31
@chalin chalin requested review from emckean and deining November 13, 2023 12:34
deining
deining approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit e6c28d3 into google:main Nov 13, 2023
@chalin chalin deleted the chalin-im-drop-prepend-2023-11-13 branch November 13, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaFC LisaFC Awaiting requested review from LisaFC

@geriom geriom Awaiting requested review from geriom

@emckean emckean Awaiting requested review from emckean

1 more reviewer

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cleanup/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop / inline prepend() SCSS function
2 participants
@chalin @deining