Skip to content

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 11, 2023

Preview, e.g.: https://deploy-preview-1727--docsydocs.netlify.app/docs/adding-content/feedback/#setup-1 -- navigate to the end of the page to see the feedback form

There are no non-whitespace changes to the generated user guide except for the changes made to the User Feedback section:

$ (cd public && git diff -bw --ignore-blank-lines -- . ':(exclude)*/_print/*' ':(exclude)*.xml') | grep ^diff
diff --git a/docs/adding-content/feedback/index.html b/docs/adding-content/feedback/index.html

@chalin chalin added docsy-docs docs about docsy analytics labels Nov 11, 2023
@chalin chalin requested review from deining and geriom November 11, 2023 13:38
@chalin chalin force-pushed the chalin-im-page-feedback-without-ga-2023-11-11 branch 4 times, most recently from c4393d2 to acd70d5 Compare November 12, 2023 23:29
@chalin chalin added this to the 23Q4 milestone Nov 13, 2023
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@chalin chalin force-pushed the chalin-im-page-feedback-without-ga-2023-11-11 branch from acd70d5 to 539514d Compare November 14, 2023 18:06
@chalin chalin merged commit 7187dea into google:main Nov 14, 2023
@chalin chalin deleted the chalin-im-page-feedback-without-ga-2023-11-11 branch November 14, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics docsy-docs docs about docsy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page feedback shouldn't require that a Google Analytics ID be set as a config parameter
2 participants