Skip to content

Auto-sync vendor assets & Hugo module versions + copyedits to README and CONTRIBUTING #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2023
Merged

Auto-sync vendor assets & Hugo module versions + copyedits to README and CONTRIBUTING #1725

merged 6 commits into from
Nov 12, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Nov 10, 2023

@chalin chalin added the CI/infra CI & infrastructure label Nov 10, 2023
@chalin chalin mentioned this pull request Nov 10, 2023
Closed
@chalin chalin requested a review from deining November 10, 2023 22:51
@chalin
Copy link
Contributor Author

chalin commented Nov 10, 2023

@deining - I've tested this using docsy-example, fetching the commit from the branch of this PR, and it works AFAICT.

@chalin chalin force-pushed the chalin-im-vendor-n-vers-2023-11-10 branch from 8ee2dcd to 71d8a52 Compare November 11, 2023 15:10
deining
deining suggested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a typo which needs to be corrected.
LGTM otherwise, haven't tested it, though.

@chalin chalin merged commit 71d8a52 into main Nov 12, 2023
@chalin
Copy link
Contributor Author

chalin commented Nov 12, 2023 •
edited
Loading

Oh dang, tripped on the buttons somehow (or was it GH Desktop?).
Or maybe because I had two branches with the same name in my fork and here ... .
Anyhow, I didn't mean to merge this yet. I'll fix the typo in a followup commit.

@chalin chalin deleted the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:38
@chalin
Copy link
Contributor Author

chalin commented Nov 12, 2023

Yeah, it wasn't the GH interface that did the merge, because it didn't squash the commits, which I have enabled by default. It must have been the GH desktop. :-(

@chalin
Copy link
Contributor Author

chalin commented Nov 12, 2023

My typo fix even made it into main!

@chalin
Copy link
Contributor Author

chalin commented Nov 12, 2023 •
edited
Loading

Ok, I've reverted the commit and will resubmit a PR ... . See:

@chalin chalin mentioned this pull request Nov 12, 2023
Merged
@chalin chalin restored the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:50
@chalin chalin deleted the chalin-im-vendor-n-vers-2023-11-10 branch November 12, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@deining deining deining requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate the updating of vendor assets Ensure that versions of dependencies remain in sync
2 participants
@chalin @deining