Skip to content

Fix creation of new child page #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix creation of new child page #1644

merged 1 commit into from
Aug 4, 2023

Conversation

deining
Copy link
Contributor

@deining deining commented Aug 3, 2023 •
edited by chalin
Loading

@deining deining added e0-minutes Effort < 60 min fix Resolves some issue in the current code base labels Aug 3, 2023
@deining deining added this to the 23Q3 milestone Aug 3, 2023
@deining deining requested a review from chalin August 3, 2023 18:22
chalin
chalin approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💛

@chalin
Copy link
Contributor

chalin commented Aug 4, 2023

I think that this feature is misnamed. I'll file an issue explaining what I mean.

@chalin chalin changed the title Fix creation of new child page (#1637) Fix creation of new child page Aug 4, 2023
@chalin chalin merged commit d30b1c9 into google:main Aug 4, 2023
@chalin chalin mentioned this pull request Aug 4, 2023
Open
@chalin
Copy link
Contributor

chalin commented Aug 4, 2023

I think that this feature is misnamed. I'll file an issue explaining what I mean.

See:

@chalin
Copy link
Contributor

chalin commented Aug 4, 2023

@deining - btw, I'd generally avoid putting a fixed issue number at the end of the PR title for two reasons:

  • When we merge, GH suffixes the title with the PR number and so, in the case of this PR, we'd end up with a commit title having suffix "(Create a new child page doesnt work. #1637) (Fix creation of new child page #1644)" ... which IMHO is confusing.
  • It's is common enough that PR's fix more than one issue and contribute to others. In such a case it doesn't make sense to select just one issue to put in the PR title.

My 2 cents. If you feel strongly about it, maybe put the issue number at the start, so we'd end up with commit log titles like "[#1637] Fix ... (#1644)"? Just a thought.

@deining deining deleted the child-page branch November 13, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chalin chalin chalin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
e0-minutes Effort < 60 min fix Resolves some issue in the current code base
Projects
None yet
Milestone
23Q3
Development

Successfully merging this pull request may close these issues.

Create a new child page doesnt work. create child page should not include the "parent" filename in the GH repo path as it breaks github's preview tab
2 participants
@deining @chalin