Skip to content

Tabpane: improve key-kind default setting #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

Tabpane: improve key-kind default setting #1643

merged 1 commit into from
Aug 3, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 3, 2023 •
edited
Loading

The only change in the generated UG is that the Welcome! tabbed panes are now persisted using the tab header as a key rather than the language:

$ (cd userguide/public && git diff -I "data-td-tp-persist=\"(en|de|ge|sw)" -- . ':(exclude)*.xml') | grep ^diff
# No change
$ (cd userguide/public && git diff -- . ':(exclude)*.xml') | grep ^diff 
diff --git a/docs/_print/index.html b/docs/_print/index.html
diff --git a/docs/adding-content/_print/index.html b/docs/adding-content/_print/index.html
diff --git a/docs/adding-content/shortcodes/index.html b/docs/adding-content/shortcodes/index.html
$ (cd userguide/public && git diff -- . ':(exclude)*.xml') | head      
...
diff --git a/docs/_print/index.html b/docs/_print/index.html
index 29d8bb8..d250b65 100644
--- a/docs/_print/index.html
+++ b/docs/_print/index.html
@@ -5396,19 +5396,19 @@ in the response headers.&rdquo; you <strong>CAN</strong> embed it, but when the
     </li><li class="nav-item">
       <button class="nav-link active"
           id="tabs-08-01-tab" data-bs-toggle="tab" data-bs-target="#tabs-08-01" role="tab"
-          data-td-tp-persist="en" aria-controls="tabs-08-01" aria-selected="true">
+          data-td-tp-persist="english" aria-controls="tabs-08-01" aria-selected="true">

@chalin chalin requested review from deining and geriom August 3, 2023 13:36
@chalin chalin mentioned this pull request Aug 3, 2023
Closed
9 tasks
deining
deining approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin merged commit c712065 into google:main Aug 3, 2023
@chalin chalin deleted the chalin-im-tabpane-key-default-2023-08-03 branch August 3, 2023 20:19
@chalin chalin mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriom geriom Awaiting requested review from geriom

1 more reviewer

@deining deining deining approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @deining