Fix: shortcode imgproc does not work with % for markdown body
#1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
chalin
reviewed
May 31, 2023
chalin
reviewed
May 31, 2023
|
I haven't tested the changes (beyond it's use in the UG), but will trust that you have. |
imgproc does not work with % for markdown body (#332)imgproc does not work with % for markdown body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #906. It contains a fix addressing and closing #332:
Two actions were needed in order to fix the issue:
endcondition of the html block containing the shortcode body (as defined in the CommonMark spec, number 7).The PR also adds a paragraph to the user guide explaining the proper use of the shortcode with different markups (markdown/html).
This PR closes #332.