Skip to content

Search resource cleanup and style tweak #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Search resource cleanup and style tweak #1434

merged 1 commit into from
Feb 22, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 22, 2023 •
edited
Loading

  • Followup to [BSv5] Adjusted offline search popover #1429
  • Runs Prettier over js/*search.js assets
    • Diff best viewed by ignoring whitespace changes
  • Makes search input field 100% wide -- we need as wide as we can get it to be.

Screenshots

Before

image

After

image
image

@chalin chalin added design/style Front-end site design / styling cleanup/refactoring labels Feb 22, 2023
chalin
chalin commented Feb 22, 2023
View reviewed changes
assets/scss/_search.scss
@@ -3,7 +3,7 @@
.td-search {
background: transparent;
position: relative;
width: 90%;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I think that this 90% was an artefact of the many iterations we did while attempting to redesign the search input box a little while back.

@chalin chalin merged commit 8228300 into google:main Feb 22, 2023
@chalin chalin deleted the chalin-im-search-tweaks-2023-02-22 branch February 22, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup/refactoring design/style Front-end site design / styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chalin