-
Notifications
You must be signed in to change notification settings - Fork 944
Closed
Labels
design/styleFront-end site design / stylingFront-end site design / stylinge0-minutesEffort < 60 minEffort < 60 min
Milestone
Description
- For context, @LisaFC isn't sure why we have ellipsis after the "Read more" text in the first place.
- Some (most?) projects don't want the ellipsis
PR #1503, as it is written now, causes the url_text
and the ui_read_more
i18n parameter to be treated inconsistently. I'd rather it be consistent. Two solutions come immediately to mind:
- Factor out the " …" from the shortcode and move it the value of
ui_read_more
in the i18n files.
This has the advantage that it would allow any language to override theui_read_more
text completely, eliminating the ellipsis, if they so choose. - Introduce a new argument to the shortcode, say
url_text_suffix
, that has a default value of " …"
Any other ideas? At the moment I prefer (1).
WDYT @LisaFC @emckean @fekete-robert @deining?
Edit: PSC consensus is to drop the ellipsis altogether.
Metadata
Metadata
Assignees
Labels
design/styleFront-end site design / stylingFront-end site design / stylinge0-minutesEffort < 60 minEffort < 60 min