Skip to content

Blocks/feature shortcode problem with ellipsis #1820

@chalin

Description

@chalin
  • For context, @LisaFC isn't sure why we have ellipsis after the "Read more" text in the first place.
  • Some (most?) projects don't want the ellipsis

PR #1503, as it is written now, causes the url_text and the ui_read_more i18n parameter to be treated inconsistently. I'd rather it be consistent. Two solutions come immediately to mind:

  1. Factor out the " …" from the shortcode and move it the value of ui_read_more in the i18n files.
    This has the advantage that it would allow any language to override the ui_read_more text completely, eliminating the ellipsis, if they so choose.
  2. Introduce a new argument to the shortcode, say url_text_suffix, that has a default value of " …"

Any other ideas? At the moment I prefer (1).

WDYT @LisaFC @emckean @fekete-robert @deining?


Edit: PSC consensus is to drop the ellipsis altogether.


Metadata

Metadata

Labels

design/styleFront-end site design / stylinge0-minutesEffort < 60 min

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions