-
Notifications
You must be signed in to change notification settings - Fork 945
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Since the following change has been applied, some previously working Mermaid diagrams report "syntax error":
But nothing has changed in the diagrams and the live Mermaid editor are fine with the Mermaid code.
I believe that the problem stems from the decision to render the code block as a <div>
rather than <pre>
:
docsy/layouts/_default/_markup/render-codeblock-mermaid.html
Lines 3 to 5 in 26d4d11
<div class="mermaid"> | |
{{- .Inner | safeHTML }} | |
</div> |
Ok, after some digging, I've found that <pre>
is _required, see Requirements for the Mermaid API:
References:
- https://github.com/google/docsy/pull/990/files#r997232082
- Screenshot when rendering fails for page https://opentelemetry.io/docs/demo/architecture/:
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working