Skip to content

Conversation

dkurt
Copy link

@dkurt dkurt commented Dec 8, 2020

Run OpenVINO processing in separate thread which let's to use common logging (3cfa6c5 + 9e69c40)

Please ignore test scripts from .github/workflows - they are not a part of patch but just used for validation.

@dkurt dkurt mentioned this pull request Dec 8, 2020
@dkurt dkurt force-pushed the openvino_logging branch 4 times, most recently from 790a18d to a2c14b4 Compare December 8, 2020 15:34
@pichuan
Copy link
Collaborator

pichuan commented Dec 10, 2020

@dkurt FYI, we might not incorporate the changes with threading. I am a bit wary of it in general.
If there's any reason I should consider it (speed?), let know.

I have one separate question for you: I'm looking into updating to Ubuntu18.04 (context: see #394 )
What should I use instead of intel-openvino-dev-ubuntu16-2020.4.287 here

sudo apt-get install -y --no-install-recommends intel-openvino-dev-ubuntu16-2020.4.287 > /dev/null
?

Thanks!

@dkurt
Copy link
Author

dkurt commented Dec 10, 2020

@pichuan, I think it's only about the speed, yes. I can benchmark it on my end and let you know if there is any benefit to use thread.

That's good idea to switch to 18.04! We can also perform switch to the latest version of OpenVINO (which was not available for 16.04):

sudo curl -o GPG-PUB-KEY-INTEL-OPENVINO-2021 https://apt.repos.intel.com/openvino/2021/GPG-PUB-KEY-INTEL-OPENVINO-2021
sudo apt-key add GPG-PUB-KEY-INTEL-OPENVINO-2021
sudo echo "deb https://apt.repos.intel.com/openvino/2021 all main" | sudo tee - a /etc/apt/sources.list.d/intel-openvino-2021.list
sudo apt-get update
sudo apt-get install -y --no-install-recommends intel-openvino-dev-ubuntu18-2021.1.110
sudo ln -s /opt/intel/openvino_2021 /opt/intel/openvino

@dkurt
Copy link
Author

dkurt commented Dec 11, 2020

You are right, there is no motivation to move this into a separate thread due current logging is already optimal! Benchmarked master and proposed branches and there is no time difference between them. Thanks!

@dkurt dkurt closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants