Pin Guava to version 33.0.0 specified in MODULE.bazel. #4681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4658 Typically, this shouldn't be an issue because we declared Guava 33.3.1 in [Dagger's pom file](https://repo1.maven.org/maven2/com/google/dagger/dagger-compiler/2.56.1/dagger-compiler-2.56.1.pom), which should force downstream users to get the upgraded dependency. However, a bug in Gradle (https://youtrack.jetbrains.com/issue/KT-76388) is currently pulling in Guava 32.1.2 onto the ClassLoader first resulting in the following error: ``` java.lang.NoSuchMethodError: 'com.google.common.collect.ImmutableSet com.google.common.graph.Graphs.reachableNodes(com.google.common.graph.Graph, java.lang.Object)' ``` RELNOTES=Fixes #4658: Pin version of Guava to the one specified in our maven.install (i.e. v33.0.0). PiperOrigin-RevId: 746529208
ab73314 to
9fc3df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin Guava to version 33.0.0 specified in MODULE.bazel.
Fixes #4658
Typically, this shouldn't be an issue because we declared Guava 33.3.1 in Dagger's pom file, which should force downstream users to get the upgraded dependency. However, a bug in Gradle (https://youtrack.jetbrains.com/issue/KT-76388) is currently pulling in Guava 32.1.2 onto the ClassLoader first resulting in the following error:
RELNOTES=Fixes #4658: Pin version of Guava to the one specified in our maven.install (i.e. v33.0.0).