Subcomponent MembersInjector error in 2.51 #4352
Description
Summary
- Using dagger.android, there is an error injecting a callback that is implemented on an
Activity/Fragment. - This only happens on
2.51and2.51.1 - It does not occur on
2.50. - Reproducible on attached sample project
- The
DaggerApplicationComponenthas a compilation error
Details
Attached is a sample project with the setup detailed in the next section below.
@ContributesAndroidInjector is leveraged, and a SubComponent is auto-generated as a result for MainActivity. The class BazPlugin needs a dependency BazCallback, which is implemented by MainActivity.
Note: BazCallback is member-injected into BazPlugin.
When building the project, there is an error:
/DaggerIssue11Jul2024/app/build/generated/source/kapt/debug/com/example/daggerissue11jul2024/DaggerApplicationComponent.java:90: error: incompatible types: BazPlugin cannot be converted to BazCallback
BazPlugin_MembersInjector.injectIBaz(instance, instance);
^
As of writing this issue, this error only appears when using dagger version 2.51.1 or 2.51. When reverting back to 2.50, the issue disappears.
Looking at the (generated) DaggerApplicationComponent, it singles out the 2nd parameter on line 90.
Note: It appears line 59 private final MainActivity instance; and line 89 private BazPlugin injectBazPlugin(BazPlugin instance) both refer to an instance. Back in version 2.50, this variable is arg0 instead of instance.
WaldoCallback and WaldoPlugin use constructor injection, and in that situation, this issue does not occur.
Before making any changes, any feedback on this issue would be appreciated.
Setup
Application and Component
class DaggerIssueApplication: DaggerApplication() {
val applicationComponent = DaggerApplicationComponent.create()
override fun applicationInjector(): AndroidInjector<out DaggerApplication> {
return applicationComponent
}
}
@Component(
modules = [AndroidInjectionModule::class, ActivityModule::class]
)
interface ApplicationComponent: AndroidInjector<DaggerIssueApplication> {
}
Modules
In addition to AndroidInjectionModule, the following Module are used
@Module
abstract class ActivityModule {
@ContributesAndroidInjector(modules = [MainActivityModule::class])
abstract fun provideMainActivity(): MainActivity
}
@Module
abstract class MainActivityModule {
@Binds
abstract fun provideBazCallback(mainActivity: MainActivity): BazCallback
@Binds
abstract fun provideWaldoCallback(mainActivity: MainActivity): WaldoCallback
}
Activity
class MainActivity : DaggerAppCompatActivity(), BazCallback, WaldoCallback {
@Inject
lateinit var pluginRegistry: PluginRegistry
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
enableEdgeToEdge()
setContentView(R.layout.activity_main)
ViewCompat.setOnApplyWindowInsetsListener(findViewById(R.id.main)) { v, insets ->
val systemBars = insets.getInsets(WindowInsetsCompat.Type.systemBars())
v.setPadding(systemBars.left, systemBars.top, systemBars.right, systemBars.bottom)
insets
}
}
override fun onResume() {
super.onResume()
pluginRegistry.init()
}
override fun bazBaz() {
}
override fun waldo() {
}
}
Supporting Classes
interface BazCallback {
fun bazBaz()
}
class BazPlugin @Inject constructor() {
@Inject lateinit var iBaz: BazCallback
}
interface WaldoCallback {
fun waldo()
}
class WaldoPlugin @Inject constructor(
private val waldoCallback: WaldoCallback
) {
}
class PluginRegistry @Inject constructor(
private val bazPlugin: BazPlugin,
private val waldoPlugin: WaldoPlugin
) {
fun init() {
}
}
Sample Project
Attached sample project. Build the app and the error will show during compilation.