Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: google/dagger
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dagger-2.49
Choose a base ref
...
head repository: google/dagger
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dagger-2.50
Choose a head ref
  • 13 commits
  • 206 files changed
  • 3 contributors

Commits on Dec 1, 2023

  1. Update Dagger yml and README with new latest version number.

    RELNOTES=N/A
    PiperOrigin-RevId: 587109243
    bcorso authored and Dagger Team committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    344e135 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Update hjar generators to output valid method bodies for methods and …

    …constructors.
    
    This CL updates Dagger's hjar generators to have valid return statements for methods with non-`void` return types and valid super calls for constructors. For example:
    
    ```
    // Example of hjar generated class with valid constructor and method bodies.
    class Foo extends FooSuper {
      Foo() {
        super(null, 0, null);
      }
    
      String stringMethod() {
        return null;
      }
    
      int intMethod() {
        return 0;
      }
    }
    ```
    
    Note that this isn't required when compiling with Turbine, but is necessary when compiling the Hjar stubs in Javac.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 588456719
    bcorso authored and Dagger Team committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    668269d View commit details
    Browse the repository at this point in the history
  2. Add a dagger.internal.Provider in order to in the future help with ad…

    …ding support for jakarta.inject.Provider.
    
    RELNOTES=Unavoidable breaking change for AssistedInject factories built at a previous version
    PiperOrigin-RevId: 588500546
    Chang-Eric authored and Dagger Team committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    75d3cbc View commit details
    Browse the repository at this point in the history
  3. Configure Bazel and Gradle to avoid spurious flakes.

    This CL updates the global `bazelrc` file to enable `--incompatible_sandbox_hermetic_tmp` to avoid tmp file collision issues between actions.
    
    This CL also updates the `gradle.properties` to give more memory to avoid Java Heap OOM issues.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 588547788
    bcorso authored and Dagger Team committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    eb9a034 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Internal changes

    RELNOTES=N/A
    PiperOrigin-RevId: 588861836
    bcorso authored and Dagger Team committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    f4b4519 View commit details
    Browse the repository at this point in the history
  2. Make minSdk and targetSdk versions consistent across Gradle tests.

    The `minSdk` is set to `16` since we test some of our artifacts on API 16.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 588910365
    bcorso authored and Dagger Team committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    45d3b87 View commit details
    Browse the repository at this point in the history
  3. Increase timeout for emulator tests from 25min to 35min in CI.

    RELNOTES=N/A
    PiperOrigin-RevId: 588931824
    bcorso authored and Dagger Team committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    45af1ed View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Optimize InjectionSiteFactory#getInjectionSites().

    RELNOTES=N/A
    PiperOrigin-RevId: 590323796
    bcorso authored and Dagger Team committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5f8b76c View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Internal changes

    RELNOTES=n/a
    PiperOrigin-RevId: 591015561
    Chang-Eric authored and Dagger Team committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    13d64c6 View commit details
    Browse the repository at this point in the history
  2. Flip the default for explicitBindingConflictsWithInject to enabled.

    RELNOTES=Flip the default for explicitBindingConflictsWithInject to enabled.
    PiperOrigin-RevId: 591064440
    Chang-Eric authored and Dagger Team committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8372c63 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Dagger build performance optimizations.

    This CL:
    
      1. Adds state to keep track of any generated monitoring modules that Dagger generates, and uses this state to eagerly defer processing of components to the next round. This is useful to avoid doing work in the current round which will likely end up getting deferred anyway due to referencing the monitoring module.
      2. Adds a cache for ComponentDescriptors similar to our caches for other descriptors to avoid recomputing these descriptors.
    
    RELNOTES=N/A
    PiperOrigin-RevId: 591092232
    bcorso authored and Dagger Team committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    be77d24 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Fix error message for an @Binds @IntoSet implementation with duplic…

    …ate bindings.
    
    This CL fixes a case where an `@Binds @IntoSet` that delegates to an implementation with duplicate bindings was throwing an `IllegalArgumentException` rather than reporting an error properly.
    
    An example of the problematic code is shown below:
    
    ```java
    @module
    interface FooModule {
      @BINDS
      @IntoSet
      Foo bindFoo(FooImpl impl);
    
      @provides
      static FooImpl provideFooImpl1() { ... }
    
      @provides
      static FooImpl provideFooImpl2() { ... }
    }
    ```
    
    The above code now reports the duplicate binding rather than throwing an `IllegalArgumentException`.
    
    RELNOTES=Fixed error message for an `@Binds @IntoSet` implementation with duplicate bindings.
    PiperOrigin-RevId: 591976664
    bcorso authored and Dagger Team committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8d01223 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. 2.50 release

    Dagger Team committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    137995b View commit details
    Browse the repository at this point in the history
Loading