[CTFE] Short cache max-age when get-entries returns fewer entries than requested #1707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CTFE get-entries handler currently returns
Cache-Control: public, max-age=86400
even when the response contains fewer entries than requested. This long cache max-age is problematic whenstart
<tree_size
<end
, because the response would be expected to change after a new entry is added to the log.To mitigate this problem whilst retaining some caching benefit, this PR implements
max-age=60
for get-entries responses that return fewer entries than requested.Checklist