Skip to content

Conversation

robstradling
Copy link
Contributor

@robstradling robstradling commented Jun 3, 2025

The CTFE get-entries handler currently returns Cache-Control: public, max-age=86400 even when the response contains fewer entries than requested. This long cache max-age is problematic when start < tree_size < end, because the response would be expected to change after a new entry is added to the log.

To mitigate this problem whilst retaining some caching benefit, this PR implements max-age=60 for get-entries responses that return fewer entries than requested.

Checklist

@robstradling robstradling requested a review from a team as a code owner June 3, 2025 15:54
@robstradling robstradling requested review from phbnf and removed request for a team June 3, 2025 15:54
@roger2hk
Copy link
Contributor

roger2hk commented Jun 3, 2025

/gcbrun

@roger2hk
Copy link
Contributor

roger2hk commented Jun 4, 2025

/gcbrun

@phbnf phbnf self-assigned this Jun 5, 2025
@phbnf
Copy link
Contributor

phbnf commented Jun 5, 2025

Thanks @robstradling !

@phbnf phbnf merged commit 55a640c into google:master Jun 5, 2025
7 checks passed
@robstradling robstradling deleted the partial_get_entries_caching branch June 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants