Suppress unnecessary duplicate key errors in the IssuanceChainStorage PostgreSQL implementation #1678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, the CTFE IssuanceChainStorage feature attempts to INSERT a row into the IssuanceChain table for every single add-chain and add-pre-chain request. Often a duplicate key exception will be raised, in which case CTFE will ignore it; however, each time such an exception is raised on the database server, an error of the following form is added to the PostgreSQL log file:
Since these "errors" are expected to occur and do not represent an actual problem, it's not useful or desirable to log them.
This PR stops adds
ON CONFLICT DO NOTHING
to the INSERT statement, so that no exception is raised and these errors will not appear in the PostgreSQL log file.Checklist