fix (ctutil/sctcheck) : fix sct validation bug when certificate chain… #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is out-of-order Signed-off-by: beardwen <beardwen@163.com>
|
Thanks for this PR. I was going to leave a comment on here suggesting an alternative way that seemed more thorough, but in the end coding it up was simpler. Take a look at #1112 and see what you think? |
Okay, thanks for your review. |
Shushangw
referenced
this pull request
Jul 13, 2023
Where the chain is out of order, look through the whole chain to find a matching issuer cert. If we don't find one, then use the fallback logic that was already there for no issuer chain provided. Added warning if issuer cert found out of position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096: failed to verify sct when the server serves a certificate chain that is out-of-order.
Checklist