Skip to content

Fix broken tests due to deleted v1 log list in testdata #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix broken tests due to deleted v1 log list in testdata #1007

merged 1 commit into from
Dec 2, 2022

Conversation

roger2hk
Copy link
Contributor

Checklist

@roger2hk roger2hk requested a review from pphaneuf November 30, 2022 13:57
@roger2hk roger2hk marked this pull request as ready for review November 30, 2022 13:57
@roger2hk roger2hk requested a review from a team as a code owner November 30, 2022 13:57
pphaneuf
pphaneuf approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pphaneuf pphaneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, but it seems the presubmit didn't run go test, that should be fixed first!

@roger2hk roger2hk merged commit 68baefe into google:master Dec 2, 2022
@roger2hk roger2hk deleted the fix-broken-test branch December 2, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pphaneuf pphaneuf pphaneuf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roger2hk @pphaneuf