client/ctclient: Fix doubled https in --log_name #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL format in v1 and v3 log lists was different - v1 doesn't include the https:// protocol, but v3 does.
pphaneuf
approved these changes
Oct 24, 2022
|
/gcbrun |
pphaneuf
suggested changes
Oct 24, 2022
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL format in Google's v1 and v3 log lists is different - v1 doesn't include the https:// protocol, but v3 does. The fix in aff1cef to use v3 log lists didn't account for this change.
Fixes #989
Checklist
I'm not sure if either of these apply; this is a simple bugfix that should have been done as part of aff1cef. It doesn't need additional documentation imo.